Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update feature flags multivariate and payloads #7791

Merged
merged 6 commits into from
Feb 13, 2024
Merged

chore: update feature flags multivariate and payloads #7791

merged 6 commits into from
Feb 13, 2024

Conversation

marandaneto
Copy link
Member

Changes

Please describe.

Add screenshots or screen recordings for visual / UI-focused changes.

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Feb 13, 2024 4:35pm

@marandaneto marandaneto requested review from neilkakkar and a team February 13, 2024 12:48
marandaneto
marandaneto commented Feb 13, 2024
View reviewed changes
contents/docs/integrate/feature-flags-code/_snippets/feature-flags-code-flutter.mdx
}
```

### Ensuring flags are loaded before usage
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog/posthog-flutter#81

@marandaneto marandaneto marked this pull request as ready for review February 13, 2024 12:49
neilkakkar
neilkakkar approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment for iOS, not sure if kotlin has the same issue.

Otherwise LGTM!

@marandaneto
Copy link
Member Author

one comment for iOS, not sure if kotlin has the same issue.

Otherwise LGTM!

nope, kotlin has the callback.

@marandaneto marandaneto reopened this Feb 13, 2024
@marandaneto marandaneto merged commit 3b7ba1c into master Feb 13, 2024
2 checks passed
@marandaneto marandaneto deleted the chore/ff-multivariate-payloads branch February 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @neilkakkar