Don't use logging in signal handler

PowerDNS · Feb 7, 2025 · 17b0f36 · 17b0f36
1 parent 56cdb4f
commit 17b0f36
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pdns/recursordist/rec_channel_rec.cc b/pdns/recursordist/rec_channel_rec.cc
@@ -1378,7 +1378,10 @@ void doExitGeneric(bool nicely)
 #if defined(__SANITIZE_THREAD__)
   _exit(0); // regression test check for exit 0
 #endif
-  g_slog->withName("runtime")->info(Logr::Notice, "Exiting on user request");
+  // Not safe from a signal handler!
+  // g_slog->withName("runtime")->info(Logr::Notice, "Exiting on user request")
+  static const string msg("Exiting on user request\n");
+  (void)write(STDERR_FILENO, msg.data(), msg.size());
 
   if (!g_pidfname.empty()) {
     unlink(g_pidfname.c_str()); // we can at least try..