rec: move to embedded web service written in Rust #15114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…libsettings.a into librecrust.a
… Cargo.lock version = 3 The default rusttls provider has quite some dependecies that need newer Rust. ring is much morer lenient.
omoerbeek
added
rec
enhancement
dependencies
zeha
reviewed
Feb 4, 2025
zeha
reviewed
Feb 4, 2025
rgacogne
reviewed
Feb 4, 2025
omoerbeek
force-pushed
the
rec-rust-web
branch
from
f711cd6 to
594f444
Compare
Pull Request Test Coverage Report for Build 13134121058Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| void RecursorWebServer::jsonstat(HttpRequest* req, HttpResponse* resp) | ||
| static void jsonstat(HttpRequest* req, HttpResponse* resp) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
omoerbeek
force-pushed
the
rec-rust-web
branch
from
594f444 to
6e1bfee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR introduces a Rust written embedded web service
Main new features
hyperandrusttls), instead of YaHTTP. We still use a few existing YaHTTP classes to represent http related data on the C++ side, but header only.settingsdirectory a been changed to the more generalrec-rust-libas it contains settings and web related code. The produced static lib is also renamed. We work in one crate as having multiple crates is a bit of a pain in combination with a static lib. See https://cxx.rs/build/other.html#linking-the-c-and-rust-together. To be revisited in the future.Future areas of improvement:
The new authentication and authorization code needs a good review to establish it's indeed equivalent to the existing code.
Checklist
I have: