Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: better explain how the recurse field works in various contexts #15128

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

omoerbeek
Copy link
Member

Short description

Plus an extra consistency check in the case of forward_zones (forward_zones_recurse cannot be done easily as the code actually does not look at the flag value, but is driven by the name of the field being processed, the incoming YAML has the flag set to false by default.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek
Copy link
Member Author

@kpfleming You might want to take a look at this PR

@omoerbeek omoerbeek added this to the rec-5.3.0 milestone Feb 7, 2025
@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13201150258

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 70 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.6%) to 64.731%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/aggressive_nsec.cc 2 66.1%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
modules/lmdbbackend/lmdbbackend.cc 2 73.65%
pdns/ws-auth.cc 2 80.8%
pdns/recursordist/syncres.cc 3 80.05%
pdns/remote_logger.cc 3 53.81%
pdns/opensslsigners.cc 3 61.27%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/rcpgenerator.cc 3 90.55%
pdns/recursordist/rec-tcp.cc 4 66.54%
Totals Coverage Status
Change from base Build 13196902717: 0.6%
Covered Lines: 128269
Relevant Lines: 167091

💛 - Coveralls

@omoerbeek omoerbeek requested a review from rgacogne February 7, 2025 12:24
pdns/recursordist/settings/docs-new-preamble-in.rst Outdated Show resolved Hide resolved
pdns/recursordist/settings/table.py Outdated Show resolved Hide resolved
@omoerbeek omoerbeek requested a review from rgacogne February 7, 2025 13:48
@omoerbeek omoerbeek merged commit c4ba47e into PowerDNS:master Feb 7, 2025
83 checks passed
@omoerbeek omoerbeek deleted the rec-fw-recurse branch February 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants