DGC-2079 Logging level to base converter #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added default = ERROR - configurable during converter construction - a small unit test checking log level of a base converter Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Jan 30, 2024
… bit Signed-off-by: Jerry Guo <[email protected]>
ToDo: test_serialize_data still fails the test for unknown reason Signed-off-by: Jerry Guo <[email protected]>
|
At the moment some of the tests are failing. They don't appear as directly related to the code added. In particular: |
Signed-off-by: Jerry Guo <[email protected]>
I did some quick digging and it seems to have to do with the fact that the structlog configure is global |
Signed-off-by: Jerry Guo <[email protected]>
|
mgovers
approved these changes
Feb 1, 2024
Jerry-Jinfeng-Guo
added
the
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation following @jeandossantos's input on Teams. Added log level, defaulted to ERROR but configurable. A small unit test is also included.