Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable internationalization for runcommandonset resource #605

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Enable internationalization for runcommandonset resource #605

merged 5 commits into from
Dec 9, 2024

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Dec 7, 2024 •
edited
Loading

PR Summary

  • Enable localization of strings for runcommandonset resource
  • clap doesn't support internationalization yet, so that'll be hardcoded English for now
  • Change direct writes to stderr to use trace which then required changes in the tests

@SteveL-MSFT SteveL-MSFT added this to the 3.0-Approved milestone Dec 7, 2024
@SteveL-MSFT SteveL-MSFT merged commit d79116f into PowerShell:3.0.0-rc1 Dec 9, 2024
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the localization branch December 9, 2024 18:00
@SteveL-MSFT SteveL-MSFT mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgauth tgauth tgauth approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0-Approved
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveL-MSFT @tgauth