Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FITB: Process statement using no mode (instead of mode="body") #2367

Closed
wants to merge 1 commit into from

Conversation

dbrianwalton
Copy link
Contributor

This should resolve #2294. Also corrects some logic and typos relating to default correct tests.

@rbeezer
Copy link
Collaborator

rbeezer commented Jan 17, 2025

Thanks for the tune-up! Merged with no code changes. Clean diff with sample book. Two notes:

  • Two topics here, two commits would be preferable.
  • I like to put spaces around logical operators (string-length()>0). Makes certain grep'ing actions easier and more reliable.

@rbeezer rbeezer closed this Jan 17, 2025
@rbeezer
Copy link
Collaborator

rbeezer commented Jan 17, 2025

You would have had an easier time if I'd thought to do the following: ;-)

#2372

@dbrianwalton
Copy link
Contributor Author

Thanks for the tips moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FITB: Elements not being retained within fillin exercises
2 participants