-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use task groups for concurrent queue consumers #16850
Conversation
8398b70
to
4c039ca
Compare
4c039ca
to
5aba2f8
Compare
CodSpeed Performance ReportMerging #16850 will not alter performanceComparing Summary
|
1cba2cb
to
ce7701b
Compare
6b90e6e
to
0c6a3f8
Compare
4c26e2a
to
f3283db
Compare
725a538
to
d13643f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all makes sense to me! The tests look great
83cb350
to
7f7152d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs changes look good
thanks! though this reminds me that I should have actually removed that new setting, this is removed now so there should be no doc-related changes here |
1c3aba2
to
0048f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple nits, but this looks like an awesome enhancement!
oops rm needless diff
rm setting from test file
793d5ef
to
009fd08
Compare
009fd08
to
719f7ec
Compare
related to #16299
the queue depth metrics were very useful while debugging and I could imagine they might be useful to server operators in the future, which I why I opted to keep it in - happy to re-evaluate this choice. doing so made me think that we may want to add more server metrics in the future