Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds Server Settings component #16903

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[UI v2] feat: Adds Server Settings component #16903

merged 1 commit into from
Feb 3, 2025
+20 −4

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 30, 2025 •
edited
Loading

1, Adds server settings UI by re-using JsonInput component.
2. Adds prop to JsonInput component to exclude line numbers

Screen.Recording.2025-01-31.at.2.31.13.PM.mov
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 30, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review February 1, 2025 01:18
@devinvillarosa devinvillarosa merged commit 0ea86f1 into main Feb 3, 2025
12 checks passed
@devinvillarosa devinvillarosa deleted the server-sttings branch February 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle