Add check on headers #1033
Merged
Add check on headers #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Quetzacoalt91
commented
Nov 22, 2024
Quetzacoalt91
commented
| Questions | Answers |
|---|---|
| Description? | Check each file being distributed has an up-to-date header about AFL-3.0. This PR adds a first commit showing the check running properly, then another commit will be added before the release of the version 7 to make sure everything is set without bringing too many conflicts. |
| Type? | improvement |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? | / |
| Sponsor company | @PrestaShopCorp |
| How to test? | CI must be triggered and must succeed |
Quetzacoalt91
force-pushed
the
header-stamp
branch
from
d7693b4 to
c694921
Compare
|
ga-devfront
force-pushed
the
header-stamp
branch
from
c694921 to
fb97224
Compare
Quetzacoalt91
commented
Feb 4, 2025
.github/workflows/build-release.yml
Outdated
Comment on lines
37
to
38
| - name: Apply header stamps | ||
| run: php tests/vendor/bin/header-stamp --license=tests/vendor/prestashop/header-stamp/assets/afl.txt --exclude=vendor,node_modules,storybook/var |
There was a problem hiding this comment.
What's the point in applying the headers on all the files if we had a check before merging pull-requests?
If you meant to update built files before release, it may be worth a comment.
…tly for header stamps
ga-devfront
force-pushed
the
header-stamp
branch
from
40f7909 to
8a5f3c8
Compare
|
M0rgan01
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.