Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure logs use the correct timezone in CLI and Web contexts #1087

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Dec 16, 2024

Questions Answers
Description? see below
Type? feature
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? See below

This PR updates the logging behavior to ensure timestamps are correctly aligned with the execution context:

  • CLI Context: Logs will use the system's timezone.
  • Web Context: Logs will use the timezone configured in the PrestaShop settings.

@M0rgan01 M0rgan01 added this to the 7.0.0 milestone Dec 16, 2024
nicosomb
nicosomb previously approved these changes Dec 16, 2024
Quetzacoalt91
Quetzacoalt91 previously approved these changes Dec 17, 2024
@AureRita AureRita self-assigned this Dec 17, 2024
@M0rgan01 M0rgan01 added the Blocked Status: The issue is blocked by another task label Dec 19, 2024
@M0rgan01 M0rgan01 dismissed stale reviews from Quetzacoalt91 and nicosomb via 2370653 February 3, 2025 09:13
@M0rgan01 M0rgan01 force-pushed the remove-force-timezone branch from dfcf3a5 to 2370653 Compare February 3, 2025 09:13
@M0rgan01 M0rgan01 changed the title [FIX] Withdrawal of the forced timezone in Paris Ensure logs use the correct timezone in CLI and Web contexts Feb 3, 2025
@M0rgan01 M0rgan01 removed the Blocked Status: The issue is blocked by another task label Feb 3, 2025
@M0rgan01 M0rgan01 force-pushed the remove-force-timezone branch 5 times, most recently from ecca142 to 4adb0ba Compare February 4, 2025 10:09
@M0rgan01 M0rgan01 force-pushed the remove-force-timezone branch from 4adb0ba to c50bfdc Compare February 5, 2025 12:39
Copy link

sonarqubecloud bot commented Feb 5, 2025

@Quetzacoalt91 Quetzacoalt91 added the new feature Type: New feature label Feb 6, 2025
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M0rgan01

Thank you for your PR, I tested it and it seems to works as you can see :

recording.63.webm

Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0

Currently we see that we have two hour different between the CLI and the web as you said it, because of that, we have not really the last rollback in the top of that as we can see in this sceenshot :

image

Moreover, on the video we can see that there is some trouble with the logs that I can't reproduce so we'll investigate on it not in this PR

Because the PR seems to works as expected, It's QA ✔️

Thank you

@Quetzacoalt91 Quetzacoalt91 merged commit b06ef67 into PrestaShop:dev Feb 6, 2025
37 checks passed
@Quetzacoalt91 Quetzacoalt91 deleted the remove-force-timezone branch February 6, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Type: New feature QA ✔️
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants