-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure logs use the correct timezone in CLI and Web contexts #1087
Conversation
|
dfcf3a5
to
2370653
Compare
ecca142
to
4adb0ba
Compare
4adb0ba
to
c50bfdc
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see :
recording.63.webm
Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Currently we see that we have two hour different between the CLI and the web as you said it, because of that, we have not really the last rollback in the top of that as we can see in this sceenshot :
Moreover, on the video we can see that there is some trouble with the logs that I can't reproduce so we'll investigate on it not in this PR
Because the PR seems to works as expected, It's QA ✔️
Thank you
This PR updates the logging behavior to ensure timestamps are correctly aligned with the execution context: