Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error management on new app, all pages excepted during the excecution of a process #1135

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add error management on new app, all pages excepted during the excecution of a process #1135

wants to merge 11 commits into from

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Jan 23, 2025 •
edited
Loading

Questions Answers
Description? Manage errors that could be triggered during ajax requests, and display the error on the screen if necessary.
Type? new feature
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? if you revert this specific commit, additional buttons displayed on the home page can be used.

image

To do list:

  • Plug existing error reporting modal, and add details
  • Update style of error page. When the HTTP is 200 or not set, do not display the left column
  • Make sure all buttons have the same style

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jan 23, 2025
@Quetzacoalt91 Quetzacoalt91 force-pushed the error-on-front-end branch 4 times, most recently from 62573c5 to ca89674 Compare January 28, 2025 18:07
@Quetzacoalt91 Quetzacoalt91 force-pushed the error-on-front-end branch 2 times, most recently from 32bbd0f to c9fdd0b Compare January 29, 2025 09:19
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review January 29, 2025 09:21
@Quetzacoalt91 Quetzacoalt91 changed the title Add error management on front end Add error management on new app, all pages excepted durring the excecution of a process Jan 29, 2025
@Quetzacoalt91 Quetzacoalt91 changed the title Add error management on new app, all pages excepted durring the excecution of a process Add error management on new app, all pages excepted during the excecution of a process Jan 29, 2025
@M0rgan01 M0rgan01 added this to the 7.0.0 milestone Jan 29, 2025
M0rgan01
M0rgan01 reviewed Jan 29, 2025
View reviewed changes
_dev/src/ts/api/responseInterceptor.ts Show resolved Hide resolved
_dev/src/ts/api/RequestHandler.ts Show resolved Hide resolved
_dev/src/ts/pages/ErrorPage.ts Outdated Show resolved Hide resolved
_dev/src/ts/pages/ErrorPage.ts Outdated Show resolved Hide resolved
_dev/src/ts/pages/ErrorPage.ts Outdated Show resolved Hide resolved
M0rgan01
M0rgan01 previously approved these changes Jan 30, 2025
View reviewed changes
ga-devfront
ga-devfront previously approved these changes Jan 30, 2025
View reviewed changes
@Quetzacoalt91 Quetzacoalt91 dismissed stale reviews from ga-devfront and M0rgan01 via f65a6ea January 30, 2025 16:42
ga-devfront
ga-devfront previously approved these changes Jan 30, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Jan 30, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ga-devfront ga-devfront ga-devfront left review comments

@M0rgan01 M0rgan01 M0rgan01 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Quetzacoalt91 Quetzacoalt91

@tblivet tblivet

Labels
None yet
Projects
PR Dashboard
Status: Ready for review
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Quetzacoalt91 @M0rgan01 @ga-devfront @tblivet