Merge pull request #190 from matks/fix-bad-delete

If user mistakenly attempts to delete a comment, fail gracefully
PrestaShop · Nov 17, 2023 · 96bc83c · 96bc83c
2 parents fae55dc + 9ccab00
commit 96bc83c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/productcomments.php b/productcomments.php
@@ -207,7 +207,13 @@ protected function _postProcess()
             $commentRepository->deleteReports($id_product_comment);
         } elseif (Tools::isSubmit('deleteproductcomments')) {
             $comment = $commentRepository->find($id_product_comment);
-            $commentRepository->delete($comment);
+
+            if ($comment === null) {
+                $this->_html .= $this->displayError($this->trans('The comment cannot be deleted', [], 'Modules.Productcomments.Admin'));
+            } else {
+                $commentRepository->delete($comment);
+                Tools::redirectAdmin($this->context->link->getAdminLink('AdminModules', true, [], ['configure' => $this->name]));
+            }
         } elseif (Tools::isSubmit('submitEditCriterion')) {
             $criterion = $criterionRepository->findRelation((int) Tools::getValue('id_product_comment_criterion'));
             $criterion->setType((int) Tools::getValue('id_product_comment_criterion_type'));