Release 3.0.0 #75
Merged
Release 3.0.0 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Sep 12, 2024
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Release 3.0.0 |
| Type? | |
| BC breaks? | |
| Deprecations? | |
| Fixed ticket? | |
| How to test? |
This drops a custom complex SQL query and uses existing helper that handles all the hard work. This simplifies module code and makes it cleaner while not changing existing behaviour. Method ::getTree() isn't used anymore so it got marked as deprecated. Other modules using it should stop doing so. Signed-off-by: Rafał Miłecki <[email protected]>
Use Category::getNestedCategories for getting subcategories
Previous logic grew into a bit complex one. It had 2 conditional parts each checking for selected BLOCK_CATEG_ROOT_CATEGORY values. They were checking for different setups and later one was conditionally modifying result of the first one. All of that made getWidgetVariables() code a bit hard to follow (understand) and hard to extend (add more scenarios). This change cleans that up. It adds a switch() and handles each BLOCK_CATEG_ROOT_CATEGORY value with a separated code. It should make code easier to understand, debug & develop. Signed-off-by: Rafał Miłecki <[email protected]>
Simplify logic for picking root category
Add badges to readme
Fix link to site
Update README.md
Co-authored-by: Daniel Hlaváček <[email protected]>
Update README.md
Refactor and add new functionality
ShaiMagal
approved these changes
Sep 14, 2024
|
@florine2623 Hello Florine, maybe just a quick glance when you just tested it in #74 ? :-) |
florine2623
added
QA ✔️
and removed
waiting for QA
|
Thank you @florine2623! :-))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.