Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync itemDrop object types in blockLoot_schema and entityLoot_schema #753

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

extremeheat
Copy link
Member

Fix #746 not updating entityLoot with blockLoot. This was failing node-minecraft-protocol CI as the typescript generation doesn't inline nested types, causing two "title": "itemDrop",'s in top level namespace to conflict with each other.

@rom1504 rom1504 merged commit 9fc22ee into PrismarineJS:master Aug 13, 2023
3 checks passed
@extremeheat
Copy link
Member Author

/makerelease 3.42.1

@extremeheat extremeheat deleted the fix-item-drop branch August 14, 2023 16:34
@rom1504bot rom1504bot mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants