Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dimension is available from 1.16.2 #877

Closed
wants to merge 2 commits into from

Conversation

zardoy
Copy link

@zardoy zardoy commented May 12, 2024

dimension data in the login packet is from 1.18 (pushing to fix the external code), however, I didn't test it with mineflayer, most probably this needs to be updated: https://github.com/PrismarineJS/mineflayer/blob/2ff9919760d714be57dcb678f8ab5ecff69f5fee/lib/plugins/game.js#L55

@extremeheat
Copy link
Member

Why would it need to be updated?

@zardoy
Copy link
Author

zardoy commented May 12, 2024

Why would it need to be updated?

Because mineflayer is not the only project using minecraft-data eg this is important for flying-squid and a few other projects

@extremeheat
Copy link
Member

Yes, I am specifically referring to your comment mentioning

dimension data in the login packet is from 1.18 (pushing fix the external code), however I didn't test it with mineflayer, most probably this needs to updated: https://github.com/PrismarineJS/mineflayer/blob/2ff9919760d714be57dcb678f8ab5ecff69f5fee/lib/plugins/game.js#L55

Please elaborate on the change needed

@rom1504
Copy link
Member

rom1504 commented Jun 9, 2024

Re open if you want to finish it

@rom1504 rom1504 closed this Jun 9, 2024
@zardoy
Copy link
Author

zardoy commented Jun 9, 2024

Re open if you want to finish it

I won't be able to reopen it if maintainer closes it

@zardoy
Copy link
Author

zardoy commented Jun 9, 2024

@rom1504 has someone ever reopened their pr after you closed it? i believe it's not possible

@rom1504
Copy link
Member

rom1504 commented Jun 9, 2024

You can say to re-open and I will if you want to finish it. Do you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants