Skip to content

Commit

Permalink
fix(cr): add missing translations, improve sortable list
Browse files Browse the repository at this point in the history
  • Loading branch information
devmiguelangel committed Jun 12, 2024
1 parent e522ae9 commit b36d9b4
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 25 deletions.
55 changes: 31 additions & 24 deletions src/components/computed-properties.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<template #options="{ item }">
<button
v-b-tooltip="{ customClass: 'bypass-btn-tooltip' }"
:title="item.byPass ? 'Unbypass Calc' : 'Bypass Calc'"
:title="item.byPass ? $t('Unbypass Calc') : $t('Bypass Calc')"
class="btn"
data-test="calcs-bypass"
@click="toggleBypass(item.id)"
Expand All @@ -52,29 +52,36 @@
</template>

<template v-else>
<required />
<form-input
ref="property"
v-model="add.property"
:label="$t('Property Name') + ' *'"
name="property"
:error="errors.property"
class="mb-3"
data-cy="calcs-property-name"
required
aria-required="true"
/>
<form-text-area
ref="name"
v-model="add.name"
:label="$t('Description') + ' *'"
name="name"
:error="errors.name"
class="mb-3"
data-cy="calcs-property-description"
required
aria-required="true"
/>
<b-container>
<b-row class="p-0">
<b-col class="pl-0">
<form-input
ref="property"
v-model="add.property"
:label="$t('Property Name') + ' *'"
name="property"
:error="errors.property"
class="mb-3"
data-cy="calcs-property-name"
required
aria-required="true"
/>
</b-col>
<b-col class="pr-0">
<form-text-area
ref="name"
v-model="add.name"
:label="$t('Description') + ' *'"
name="name"
:error="errors.name"
class="mb-3"
data-cy="calcs-property-description"
required
aria-required="true"
/>
</b-col>
</b-row>
</b-container>
<div class="form-group mb-3" style="position: relative">
<label v-show="isJS">{{ $t("Formula") + " *" }}</label>
<div class="float-right">
Expand Down
2 changes: 1 addition & 1 deletion src/components/sortable/sortableList/SortableList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</div>
<div
v-for="(item, index) in sortedItems"
:key="index"
:key="`item-${index}`"
:data-order="item.order"
:data-test="`item-${item.order}`"
:title="item.name"
Expand Down

0 comments on commit b36d9b4

Please sign in to comment.