Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOUR-4913] Removed defaultValues from Advanced tab and added unselected option (4.2) #1137

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

josechirivella
Copy link
Contributor

Even though we removed the defaultValue from the advance tab, we had some functionality to set the defaultValues using radio buttons next to the options, which wasn't working previously but fixed those and added some e2e

End result:
Screen Shot 2021-12-22 at 11 20 11 AM

Things to test

  • defaultValue box in advance tab shouldn't show
  • radio buttons should set the default value
  • Switching between returned value type should set the correct default value since the data model changes between
  • E2E test is passing on my end but make sure that they are passing on your end

@josechirivella josechirivella self-assigned this Dec 22, 2021
@josechirivella josechirivella changed the title [FOUR-4913] [FOUR-4913] Removed defaultValues from Advanced tab and added unselected option (4.2) Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants