Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-6507: Interstitial keeps loading and the summary is not displayed when having Send Email task as the final task #1242

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

agustinbusso
Copy link
Contributor

Issue & Reproduction Steps

Create a process with 2 tasks with the option Load Next Assigned task ... checked, and:

  • For Task 1 set assignment rules to User A

  • For Task 2 set assignment rules to User B

  • Run a request

  • Complete the first task.

  • Process get stuck in interstitial screen.

Explanation:
When complete the first task and then tries to loadNextAssignedTask for User A, the list of tasks for user A is empty (no pending tasks for user A) so is not redirecting to task list (process is not completed yet because there are another task pending for User B) and process get stuck in interstitial screen.

Expected behavior:
When process still active (maybe because another user have pending tasks and process is not completed), with Load Next Assigned task option active, after complete Task 1, the process should redirect to task list.

Actual behavior:
After complete the first task process get stuck in interstitial screen.

Solution

  • In loadNextAssignedTask method after retrieve the list of task for current user (?user_id=${this.userId}), if not pending tasks for the current user AND process still active, redirect to task list.

Working video

Screen.Recording.2022-08-02.at.12.50.54.mov

Screen Shot 2022-08-02 at 12 36 57

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant