Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File-Upload component #1325

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix File-Upload component #1325

wants to merge 5 commits into from

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Feb 1, 2023

Issue & Reproduction Steps

Fix reactivity issues.

Solution

  • Remove the use of deep: true.
  • Reduce the use of computed and watchers.
  • Fix lint issues

How to Test

Create screens with file upload components in the following cases:

  • Single file
  • Multiple files
  • Inside loops
  • Inside record lists

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@caleeli caleeli marked this pull request as ready for review February 1, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants