Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Vite 🚀 #1428

Closed
wants to merge 46 commits into from
Closed

Introducing Vite 🚀 #1428

wants to merge 46 commits into from

Conversation

josechirivella
Copy link
Contributor

@josechirivella josechirivella commented Aug 15, 2023

  • The final build increased but it can be reduced by adding some external deps available in Core
  • The dev server gets launched in about 1 sec
  • Final build takes about 10-15 secs but it can be reduced by disabling source maps

Depends of

* Renamed the babel config file to json
* Moved the index.html from public and moved it to the root folder. Did some modifications to load the main.js file
* Importing the correct functions and components from VueFormElements
* Added the name property to some VueComponents. This has to be done in all the vue files
* Added languageWorker on languages to be imported from Monaco
* Removed type: module from the package.json. Was giving me some issues with eslint
…importing the css automatically from the JS file
…p since it was the one working

* Removed the optimizeDeps for Monaco
* Added .babelrc
* Added coverage folder to the things not to watch for changes
# Conflicts:
#	package-lock.json
#	src/components/inspector/form-multiselect.vue
#	src/components/renderer/form-masked-input.vue
#	src/components/vue-form-builder.vue
…porting Scrollparent. Also enabling sourcemaps
# Conflicts:
#	package-lock.json
#	src/components/vue-form-builder.vue
#	src/main.js
@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Reliability Rating on New Code (is worse than A)
Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

Copy link

cypress bot commented Jan 5, 2024

1 failed test on run #231 ↗︎

1 0 0 8 Flakiness 0

Details:

Merge 5f9202b into f8e6763...
Project: screen-builder Commit: 8cf3b69c1d ℹ️
Status: Failed Duration: 00:06 💡
Started: Jan 8, 2024 7:45 PM Ended: Jan 8, 2024 7:45 PM
Failed  ValidationRules.spec.js • 1 failed test

View Output

Test Artifacts
Validation Rules > Invalid default values Screenshots
Failed  SelectListDependent.spec.js • 0 failed tests

View Output

Test Artifacts
Failed  Watchers.spec.js • 0 failed tests

View Output

Test Artifacts
Failed  DeviceVisivilityInspector.spec.js • 0 failed tests

View Output

Test Artifacts
Failed  RecordList.spec.js • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 76 specs in Cypress Cloud.

Review all test suite changes for PR #1428 ↗︎

Copy link

Quality Gate failed Quality Gate failed

Failed conditions

6 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant