Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13914 | The Language Selected for a User Is Not Complete #1532

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Feb 9, 2024

Issue

Ticket: FOUR-13914

When a language is selected for a user, all strings are not translated into the selected language.

Solution

  • Ensure missing translations are wrapped in the $t(...) translation method.
  • Ensure missing translations are added to the language JSON files.

How to Test

  1. Go to branch observation/FOUR-13914-b in processmaker.
  2. Go to branch observation/FOUR-13914-b in screen-builder.
  3. Create a user. Change their language to es for Spanish.
  4. Ensure that the text on the following pages is translated into Spanish:
    • Homepage (Custom Dashboard text)
    • Processes
    • Designer

ci:next
..

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Feb 9, 2024

1 failed test on run #419 ↗︎

1 104 3 1 Flakiness 0

Details:

FOUR-13914 | The Language Selected for a User Is Not Complete
Project: screen-builder Commit: 3998dc320d
Status: Failed Duration: 03:46 💡
Started: Feb 14, 2024 6:06 PM Ended: Feb 14, 2024 6:10 PM
Failed  DatePicker.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Date Picker > Date Time Picker should have the class .datePicker applied in design mode Test Replay Screenshots
Failed  FOUR6788_ScreenPerformanceTests.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  FormTextArea.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  Loop.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  SelectListCollection.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts

The first 5 failed specs are shown, see all 71 specs in Cypress Cloud.

Review all test suite changes for PR #1532 ↗︎

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@josechirivella
Copy link
Contributor

The datepicker test can be ignored, is a flaky test. You have my approval on this

@ryancooley ryancooley merged commit f88dda1 into next Feb 14, 2024
41 of 49 checks passed
@ryancooley ryancooley deleted the observation/FOUR-13914-b branch February 14, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants