FOUR-13453 order calcs list with drag and drop option #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #806 ↗︎
Details:
Review all test suite changes for PR #1612 ↗︎ |
|||||||||||||||
devmiguelangel
force-pushed
the
feature/FOUR-13453
branch
from
c589783 to
1922884
Compare
devmiguelangel
force-pushed
the
feature/FOUR-13453
branch
from
1922884 to
e522ae9
Compare
caleeli
reviewed
Jun 11, 2024
| <template #options="{ item }"> | ||
| <button | ||
| v-b-tooltip="{ customClass: 'bypass-btn-tooltip' }" | ||
| :title="item.byPass ? 'Unbypass Calc' : 'Bypass Calc'" |
There was a problem hiding this comment.
Add translation for this labels
There was a problem hiding this comment.
translations were added
caleeli
reviewed
Jun 11, 2024
| </div> | ||
| <div | ||
| v-for="(item, index) in sortedItems" | ||
| :key="index" |
There was a problem hiding this comment.
Consider to add a prefix to the :key like:
Suggested change
| :key="index" | |
| :key="`item-${index}`" |
There was a problem hiding this comment.
prefix was added
rodriquelca
approved these changes
Jun 12, 2024
caleeli
approved these changes
Jun 12, 2024
|
0.0% Coverage on New Code
17.9% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
As a designer, I want to have the option to Order the list of Calcs that I am creating in the Screen Builder.
Related Tickets & Packages
FOUR-13453
Code Review Checklist
ci:next