Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert the Bypass Option in each Calc #1616

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Jun 12, 2024

Issue & Reproduction Steps

Expected behavior:
As a Designer I want to have the option to Bypass a selected list of Calcs that I am creating in the Screen Builder.
Actual behavior:
n/a

Solution

  • add byPass logic to avoid if the property byPass is true
Screen.Recording.2024-06-12.at.10.44.13.AM.mov

How to Test

Test the steps above
CASE 1

  • create a screen
  • create a input field
  • add a calc
  • use the calc variable to set as default value
  • preview the screen
  • default value must be populated by calc
    CASE 2
  • create a screen
  • create a input field
  • add a calc
  • set this calc as byPass true
  • use the calc variable to set as default value
  • preview the screen
  • default value must not be populated by calc

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Jun 12, 2024

Passing run #809 ↗︎

0 275 19 0 Flakiness 0

Details:

Insert the Bypass Option in each Calc
Project: screen-builder Commit: 7173767c07
Status: Passed Duration: 07:10 💡
Started: Jun 12, 2024 4:20 PM Ended: Jun 12, 2024 4:27 PM

Review all test suite changes for PR #1616 ↗︎

Copy link

@caleeli caleeli merged commit 6d18015 into feature/FOUR-13452 Jun 13, 2024
27 checks passed
@caleeli caleeli deleted the feature/FOUR-13454 branch June 13, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants