Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix-FOUR:19706: Improve error message when SVG's fails to upload - Fall #1754

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Oct 23, 2024

Issue & Reproduction Steps

This PR addresses the issue where error messages were unclear when SVG file uploads failed. The existing error message was not specific enough, making it difficult for users to understand why the file upload was failing.

  • Navigate to the file manager
  • Upload attached SVG within the ticket.
  • The file fails to upload and is unclear why.

Expected behavior:

  • Give a reasonable human readable feedback to the user

Actual behavior:

  • Unclear error message

Solution

  • Improved error handling for SVG file uploads.
  • Updated the error message to provide more specific details about the failure (e.g., unsupported tags).
  • Refined validation logic to catch SVG-related issues early and report them more clearly to the user.
  • Give feedback in how to resolve the issue to the user.
  • Screenshot 2024-10-21 at 10 46 23 PM

How to Test

Please follow the Reproduction Steps and Make sure that the Expected behavior is met.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 23, 2024

screen-builder    Run #1599

Run Properties:  status check passed Passed #1599  •  git commit 96c70bce91: Bugfix-FOUR:19706: Improve error message when SVG's fails to upload - Fall
Project screen-builder
Branch Review bugfix/FOUR-19706-fall
Run status status check passed Passed #1599
Run duration 36m 42s
Commit git commit 96c70bce91: Bugfix-FOUR:19706: Improve error message when SVG's fails to upload - Fall
Committer Esteban Gallego
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 341
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit ac8ac33 into release-2024-fall Oct 25, 2024
37 of 42 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19706-fall branch October 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants