Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/FOUR-19806: Collection columns not selected in Edit Screens are deleted when Draft data is recovered in task using CollectionRecordControl #1761

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

CarliPinell
Copy link
Contributor

@CarliPinell CarliPinell commented Oct 25, 2024

Expected behavior:

  • When a task with Collection Record Control has data recovered from DRAFT, once Form is submited, only fields displayed in the screen must be updated in Collection's Table.

Solution

  • Only fields on the collection edit screen are updated, and fields that are not displayed remain unchanged in the database.

How to Test

-Login PM4

  • Go to Designer-> screens
  • Create or use previous screens
  • Drag Collection Record Control
  • Choose a collection that does not show all its fields on screen in Edit Mode and with "Update on submit" checked
  • Save and Start a case with that screen
  • Change values from collection fields and wait for auto save as Draft.
  • Reload the Screen to recover Draft data
  • Submit the form
  • Go to Collections and review all Collection Fields remain correct (There should be no columns removed after submit)

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-19806

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ..

Copy link

cypress bot commented Oct 25, 2024

screen-builder    Run #1644

Run Properties:  status check passed Passed #1644  •  git commit 18d73cb910: bugfix/FOUR-19806: Collection columns not selected in Edit Screens are deleted w...
Project screen-builder
Branch Review bugfix/FOUR-19806
Run status status check passed Passed #1644
Run duration 08m 48s
Commit git commit 18d73cb910: bugfix/FOUR-19806: Collection columns not selected in Edit Screens are deleted w...
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 342
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
image

@ryancooley ryancooley merged commit bd632ad into release-2024-fall Oct 29, 2024
23 of 28 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19806 branch October 29, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants