Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-19847: column field is not reset when single field of record is changed by single record #1764

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

CarliPinell
Copy link
Contributor

Solution

  • Column field is reset when Data selection options are changed
  • Design option in Inspector shows the respective colors of the selected option in Table Style Dropdown

How to Test

TEST 1

-Login PM4

  • Go to Designer-> screens
  • Create or use previous screens
  • Drag Collection Record List and change name to "list"
  • Select some Collection and create some Columns to display
  • In configuration option, Select 'Single field of record' in Data Selection Dropdown
  • Select some column in dropdown Column
  • Select a Rich Text and wrap in mustache syntax {{list}}
  • Click on preview, and select one row. The value of column selected should be displayed on rich text
  • Now change Data Selection dropdown to "Single Record" option
  • Change Rich Text mustache syntax to {{list.NameOfCollectionColumn}}
  • Click on Preview and select one row. The value of column selected should be displayed on rich text

TEST 2

  • In the same Screen, keeping test 1 changes, click on Record List
  • Go to Design and select "MODERN"
  • Choose one color
  • Header background color of Record List must change
  • Save the screen, and refresh the page.
  • Once Screen loads again, click on Record List, go to Design.
  • Dropdown must display MODERN option.
  • Add a Input Field to the screen
  • Go to Design. There should be no any dropdown to select Modern or Classic.
  • Chose some Text and Background colors for input field. Record List and Input field styles should be independent.

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-19847

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 28, 2024

screen-builder    Run #1651

Run Properties:  status check passed Passed #1651  •  git commit 7f229a5200: Bugfix/FOUR-19847: `column` field is not reset when `single field of record` is ...
Project screen-builder
Branch Review bugfix/FOUR-19847
Run status status check passed Passed #1651
Run duration 08m 47s
Commit git commit 7f229a5200: Bugfix/FOUR-19847: `column` field is not reset when `single field of record` is ...
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 343
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit d866e0e into release-2024-fall Oct 30, 2024
15 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19847 branch October 30, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants