Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-20097:Record ID field does not work to Collection Record Control #1771

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

CarliPinell
Copy link
Contributor

@CarliPinell CarliPinell commented Nov 11, 2024

Solution

  • Fix was implemented to use draft data only when record id of collection does not change

How to Test

  • Login PM
  • Go to Designer->screens
  • Create or select a screen
  • Drag Collection Record Control and Input Field
  • In Collection Record Control name Record ID with Input field variable name in mustache syntax (i.e {{record_id}})
  • Choose Edit or View Mode
  • Save Screen and assign it to a Process.
  • Run a Case with last screen modified
  • Enter different Record ID numbers in Input Field, each record Id must shown respective collection data
  • Enter an specific Record ID, change some information in the screen and wait for autosave.
  • Refresh page. Draft data must be recovered in the screen.

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-20097

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    .

Copy link

cypress bot commented Nov 11, 2024

screen-builder    Run #1673

Run Properties:  status check passed Passed #1673  •  git commit c96edd8652: Bugfix/FOUR-20097:`Record ID` field does not work to Collection Record Control
Project screen-builder
Branch Review bugfix/FOUR-20097
Run status status check passed Passed #1673
Run duration 09m 31s
Commit git commit c96edd8652: Bugfix/FOUR-20097:`Record ID` field does not work to Collection Record Control
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gproly gproly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Contributor

@gproly gproly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress tests have failed.

@ryancooley ryancooley merged commit b696a3c into release-2024-fall Nov 12, 2024
26 of 28 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-20097 branch November 12, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants