Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation/FOUR-19978: Not all strings are added to the Json file for translation. #1774

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Nov 13, 2024

Issue & Reproduction Steps

Steps to reproduced:

  • Select a language
  • Log in with an admin user
  • Go to the Home tab
  • Go to the Admin tab and click Translations
  • Go to the Designer tab
  • Go to the Tasks tab
  • Go to the Cases tab
  • Go to the Processes tab

Current Behavior:
There are several untranslated fields.

  • In Home--No Cases to Show, START NEW CASE
  • In translations--Add language, Source String (English), botton translate with AI, the options select all fields, select empty - files, Default Anon language
  • In designer--Name, Modified
  • In tasks--Drafts, status
  • In Cases--My cases, In progress, All cases, my requests, case, Case title, Process, task, participants, status, started completed, No new cases at this moment.
  • In processes--Search Categories and processes

Solution

  • Translate missing texts

IMPORTANT

Some translations are missing in the es.json file, we need to manually run the script to translate missing transaltions.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Nov 13, 2024

screen-builder    Run #1677

Run Properties:  status check passed Passed #1677  •  git commit b9a79ae16f: Observation/FOUR-19978: Not all strings are added to the Json file for translati...
Project screen-builder
Branch Review observation/FOUR-19978
Run status status check passed Passed #1677
Run duration 09m 22s
Commit git commit b9a79ae16f: Observation/FOUR-19978: Not all strings are added to the Json file for translati...
Committer Agustín Busso
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 365
View all changes introduced in this branch ↗︎

@ryancooley ryancooley merged commit 138e4fa into release-2024-fall Nov 13, 2024
24 of 28 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19978 branch November 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants