replace UI_UTIL_read_pw_string with EVP_read_pw_string #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes building with LibreSSL 4.0.0, which removed the UI_UTIL API
|
Does this still work with OpenSSL 1.1.1? |
|
It builds with homebrew's OpenSSL 1.1.1w. 1.1.1 is EOL though so you should probably stop using it. |
|
Got the time to do actual testing with 1.1.1 and it seems to work exactly the same. |
|
Do you need me to do anything more before this can be merged? |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building with LibreSSL 4.0.0, which removed the UI_UTIL API.
I've done some basic testing and it seems to work identically.
Fixes #43