Merge pull request #601 from JeroenDeDauw/void

Add void return hints
ProfessionalWiki · Feb 9, 2020 · 4c3b0f1 · 4c3b0f1
2 parents 7ff9459 + db29cc5
commit 4c3b0f1
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 13 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -12,9 +12,9 @@ matrix:
       php: 7.1
     - env: DBTYPE=sqlite; MW=1.33.0; SMW=3.1.0
       php: 7.2
-    - env: DBTYPE=mysql; MW=master
-      php: 7.3
     - env: DBTYPE=mysql; MW=master; SMW=dev-master; TYPE=coverage
+      php: 7.3
+    - env: DBTYPE=mysql; MW=master
       php: 7.4
 
 install:

diff --git a/tests/Integration/DataAccess/GeoJsonFetcherTest.php b/tests/Integration/DataAccess/GeoJsonFetcherTest.php
@@ -41,7 +41,7 @@ class GeoJsonFetcherTest extends TestCase {
 	 */
 	private $fileFetcher;
 
-	public function setUp() {
+	public function setUp(): void {
 		$this->fileFetcher = new StubFileFetcher( json_encode( self::VALID_FILE_JSON ) );
 
 		$page = new \WikiPage( Title::newFromText( self::EXISTING_GEO_JSON_PAGE_WITH_PREFIX ) );

diff --git a/tests/Integration/DataAccess/MediaWikiFileUrlFinderTest.php b/tests/Integration/DataAccess/MediaWikiFileUrlFinderTest.php
@@ -19,7 +19,7 @@ class MediaWikiFileUrlFinderTest extends TestCase {
 	 */
 	private $urlFinder;
 
-	public function setUp() {
+	public function setUp(): void {
 		$this->urlFinder = new MediaWikiFileUrlFinder();
 	}
 

diff --git a/tests/Integration/MapsDistanceParserTest.php b/tests/Integration/MapsDistanceParserTest.php
@@ -61,7 +61,7 @@ class MapsDistanceParserTest extends TestCase {
 		'3.4.2 km'
 	];
 
-	public function setUp() {
+	public function setUp(): void {
 		if ( !defined( 'MEDIAWIKI' ) ) {
 			$this->markTestSkipped( 'MediaWiki is not available' );
 		}

diff --git a/tests/Integration/MapsMapperTest.php b/tests/Integration/MapsMapperTest.php
@@ -13,7 +13,7 @@
  */
 class MapsMapperTest extends TestCase {
 
-	public function setUp() {
+	public function setUp(): void {
 		if ( !defined( 'MEDIAWIKI' ) ) {
 			$this->markTestSkipped( 'MediaWiki is not available' );
 		}

diff --git a/tests/Integration/MediaWiki/ParserHooks/ParserHookTest.php b/tests/Integration/MediaWiki/ParserHooks/ParserHookTest.php
@@ -12,7 +12,7 @@
  */
 abstract class ParserHookTest extends TestCase {
 
-	public static function setUpBeforeClass() {
+	public static function setUpBeforeClass(): void {
 		if ( !defined( 'MEDIAWIKI' ) ) {
 			self::markTestSkipped( 'MediaWiki is not available' );
 		}

diff --git a/tests/Integration/Parser/DisplayMapTest.php b/tests/Integration/Parser/DisplayMapTest.php
@@ -14,12 +14,12 @@ class DisplayMapTest extends TestCase {
 	private $originalHeight;
 	private $originalWidth;
 
-	public function setUp() {
+	public function setUp(): void {
 		$this->originalHeight = $GLOBALS['egMapsMapHeight'];
 		$this->originalWidth = $GLOBALS['egMapsMapWidth'];
 	}
 
-	public function tearDown() {
+	public function tearDown(): void {
 		$GLOBALS['egMapsMapHeight'] = $this->originalHeight;
 		$GLOBALS['egMapsMapWidth'] = $this->originalWidth;
 	}

diff --git a/tests/Integration/Semantic/ValueDescriptions/AreaDescriptionTest.php b/tests/Integration/Semantic/ValueDescriptions/AreaDescriptionTest.php
@@ -15,7 +15,7 @@
  */
 class AreaDescriptionTest extends TestCase {
 
-	public function setUp() {
+	public function setUp(): void {
 		if ( !defined( 'SMW_VERSION' ) ) {
 			$this->markTestSkipped( 'SMW is not available' );
 		}

diff --git a/tests/Integration/parsers/LocationParserTest.php b/tests/Integration/parsers/LocationParserTest.php
@@ -20,7 +20,7 @@ class LocationParserTest extends TestCase {
 	private $fileUrlFinder;
 	private $useAddressAsTitle;
 
-	public function setUp() {
+	public function setUp(): void {
 		$this->geocoder = new StubGeocoder( new LatLongValue( 1, 2 ) );
 		$this->fileUrlFinder = new MediaWikiFileUrlFinder();
 		$this->useAddressAsTitle = false;

diff --git a/tests/System/SemanticMW/MapQueryTest.php b/tests/System/SemanticMW/MapQueryTest.php
@@ -27,7 +27,7 @@ class MapQueryTest extends TestCase {
 	 */
 	private $contentFetcher;
 
-	public function setUp() {
+	public function setUp(): void {
 		if ( !defined( 'SMW_VERSION' ) ) {
 			$this->markTestSkipped( 'SMW is not available' );
 		}

diff --git a/tests/Unit/Semantic/DataValues/CoordinateValueTest.php b/tests/Unit/Semantic/DataValues/CoordinateValueTest.php
@@ -18,7 +18,7 @@
  */
 class CoordinateValueTest extends TestCase {
 
-	public function setUp() {
+	public function setUp(): void {
 		if ( !defined( 'SMW_VERSION' ) ) {
 			$this->markTestSkipped( 'SMW is not available' );
 		}