DEV-1 init Авторизации приложения в домен для доступа к информации о принтерах в веб-приложении #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Добавил UnitTest.
Добавил метод для поиска принтеров. Добавил пакет System.DirectoryServices.
Добавил 3 новые настройки: DomainPath, DomainUserName, DomainPassword.
NotTastyCupcake
approved these changes
Nov 11, 2023
Перенос SearchDeviceService в Domain. Переименнование Domain в Domain_Win. Исправление пространства по умолчанию имен для Cross_Cutting.
NotTastyCupcake
requested review from
a team and
Zeerck
and removed request for
a team
Вынес авторизацию в домене в отдельный класс вместе с интерфейсом. Общие правки по внешнему виду.
Изменил метод GetEntry интерфейса IAuthDomain на поле Root и его реализациях.
NotTastyCupcake
changed the title
|
Тест |
Создал проект для интеграционного тестирования. Саздал интеграционный тест для сервиса поиска принтеров (SearchDeviceService).
Доработал тест сервиса на получение списка принтеров.
NotTastyCupcake
approved these changes
Dec 18, 2023
| @@ -8,6 +8,6 @@ namespace ProgGym.PrinterMonitor.Application.Interfaces | |||
| { | |||
| public interface ISearchDeviceService | |||
| { | |||
|
|
|||
| public List<string?> GetPrinters(); | |||
There was a problem hiding this comment.
При получении коллекция должна быть не мутабельна, рекомендуется использовать readonly коллекциии
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил UnitTest.