add memory-gi-unit feature #423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengrongfu
force-pushed
the
feat/memory-use-gi-unit
branch
3 times, most recently
from
828a198
to
fc8f02f
Compare
Signed-off-by: rongfu.leng <[email protected]>
lengrongfu
force-pushed
the
feat/memory-use-gi-unit
branch
from
fc8f02f
to
0d96d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #421
Special notes for your reviewer:
User can set
--memory-gi-unitwhen startschedulerpod, then convert the memory unit from Gi to Mb through webhook, by setting 0.001, you can also achieve 1M.Does this PR introduce a user-facing change?: