fix grafana dashboard and clarify dashboard usage more clearly. #543
Conversation
| image: nvcr.io/nvidia/k8s/cuda-sample:vectoradd-cuda10.2 | ||
| resources: | ||
| limits: | ||
| nvidia.com/vgpu: 2 # requesting 2 vGPUs |
There was a problem hiding this comment.
Should "nvidia.com/vgpu" be "nvidia.com/gpu"?
There was a problem hiding this comment.
Should "nvidia.com/vgpu" be "nvidia.com/gpu"?
I forgot to explain it, it depends on our own case.
In order to distinguish from “nvidia.com/gpu” in nvidia-device-plugin, I used resourceName parameter and setted it's value to "nvidia.com/vgpu", such as: helm install hami hami-charts/hami --set resourceName=nvidia.com/vgpu --set scheduler.kubeScheduler.imageTag=v1.23.10 -n kube-system
|
@fangfenghuang Can you help review this pr? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
docs/dashboard.md
Outdated
|
|
||
| You can see the monitoring details in the dashboard. The contents are as follows: | ||
|
|
||
|  |
There was a problem hiding this comment.
It is best to place the referenced images in the ../imgs/
…he image display problem in document and document format Signed-off-by: jiangsanyin <[email protected]>
Signed-off-by: jiangsanyin [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix grafana dashboard and clarify dashboard usage more clearly. Thanks "fangfenghuang (https://github.com/fangfenghuang)" for your help
Which issue(s) this PR fixes:
Fixes #498 #468
Special notes for your reviewer:
Does this PR introduce a user-facing change?: