Fix Kubernetes version string handling by stripping metadata #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nimbus318
force-pushed
the
fix/strip-kubernetes-version
branch
from
6b99919
to
295abc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
added 2 commits
November 16, 2024 13:37
…er `+` This fix ensures that Kubernetes version strings with additional metadata (e.g., `+k3s1`) are properly handled. The function `strippedKubeVersion` is introduced to remove the part after the `+`, resolving issues with version compatibility in dynamically generated image tags. Signed-off-by: Nimbus <[email protected]>
Signed-off-by: Nimbus <[email protected]>
Nimbus318
force-pushed
the
fix/strip-kubernetes-version
branch
from
468852e
to
db167c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an issue where Kubernetes version strings with additional metadata (e.g.,
+k3s1) caused problems in dynamically generated image tags. The newstrippedKubeVersionfunction removes the part after the+in the Kubernetes version string, ensuring consistent and predictable image tagging.Which issue(s) this PR fixes:
Fixes #621
Special notes for your reviewer:
@archlitchi
@wawa0210
Does this PR introduce a user-facing change?:
Yes, this PR restores compatibility for specifying certain parameters during
helm install/upgrade.After version 2.4.1, users were unable to specify parameters like
scheduler.kubeScheduler.tag(scheduler image version),devicePlugin.deviceSplitCount,devicePlugin.deviceMemoryScaling, anddevicePlugin.deviceCoreScalingdirectly during Helm operations.With this PR merged:
scheduler.kubeScheduler.tagduringhelm installorhelm upgrade. If the parameter is not provided, the image version will continue to be auto-generated based on the Kubernetes version.deviceSplitCount,deviceMemoryScaling, anddeviceCoreScalingare also restored for direct specification during Helm operations.