Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr Merger #6633

Merged
merged 24 commits into from
Jun 28, 2023
Merged

Zarr Merger #6633

merged 24 commits into from
Jun 28, 2023

Conversation

drbeh
Copy link
Member

@drbeh drbeh commented Jun 20, 2023

Fixes #6006

Description

This PR implements ZarrAvgMerger which can be used for patch inference. Also a use case is demonstrated here.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@drbeh drbeh changed the title Zarr mergers Zarr Merger Jun 20, 2023
@drbeh drbeh requested a review from JHancox June 21, 2023 00:54
@ericspod
Copy link
Member

We do also need tests to cover this code. Zarr does look interesting, I wonder if it would have other application MONAI, eg. data handling in transforms.

monai/inferers/merger.py Outdated Show resolved Hide resolved
@drbeh drbeh enabled auto-merge (squash) June 22, 2023 17:02
@drbeh drbeh disabled auto-merge June 22, 2023 17:02
monai/inferers/merger.py Outdated Show resolved Hide resolved
Signed-off-by: Behrooz <[email protected]>
@drbeh drbeh requested review from ericspod and JHancox June 26, 2023 15:07
@drbeh
Copy link
Member Author

drbeh commented Jun 26, 2023

Hi @ericspod, please take another look and let me know if you have any other comments. Thanks

@drbeh drbeh enabled auto-merge (squash) June 27, 2023 19:45
monai/inferers/merger.py Outdated Show resolved Hide resolved
@drbeh drbeh requested review from wyli and JHancox June 28, 2023 13:47
@wyli
Copy link
Contributor

wyli commented Jun 28, 2023

/build

@drbeh drbeh disabled auto-merge June 28, 2023 13:59
@drbeh drbeh enabled auto-merge (squash) June 28, 2023 13:59
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, @ericspod please feel free to follow up if anything missing

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had just very minor changes to docs.

monai/inferers/merger.py Outdated Show resolved Hide resolved
monai/inferers/merger.py Outdated Show resolved Hide resolved
monai/inferers/merger.py Outdated Show resolved Hide resolved
monai/inferers/merger.py Show resolved Hide resolved
drbeh and others added 4 commits June 28, 2023 13:11
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Dr. Behrooz Hashemian <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Dr. Behrooz Hashemian <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Dr. Behrooz Hashemian <[email protected]>
@wyli
Copy link
Contributor

wyli commented Jun 28, 2023

/build

@drbeh drbeh merged commit ae95bf9 into Project-MONAI:dev Jun 28, 2023
@drbeh drbeh deleted the zarr-mergers branch June 28, 2023 18:16
drbeh added a commit to Project-MONAI/tutorials that referenced this pull request Jul 4, 2023
This PR add an example for `ZarrAvgMerger` to be plugged into
`PatchInferer` along with `WSISlidingWindowSplitter`.

Note: Project-MONAI/MONAI#6633 in MONAI core
should be merged before this one.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Behrooz <[email protected]>
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
This PR add an example for `ZarrAvgMerger` to be plugged into
`PatchInferer` along with `WSISlidingWindowSplitter`.

Note: Project-MONAI/MONAI#6633 in MONAI core
should be merged before this one.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Zarr Merger
6 participants