6699 random sort grid patch

[jmnolte]

Description

The PR introduces a random sorting option to the GridPatch, RandGridPatch, GridPatchd, RandGridPatchd transforms. So far, the transforms allowed patches to be sorted according to the sum of their intensity or in their default order (i.e., sliding-window manner). With this PR, random extraction of patches as described in Myronenko et al. is enabled.

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• New tests added to cover the changes.

[drbeh]

@jmnolte Thanks for your contribution. The only downside of implementing the randomness is GridPatch is that this transform is supposed to be non-random while relying on its random counter part RandGridPatch to include randomness. Thus, I would suggest to only modify RandGridPatch for this purpose by overriding its filter_count method, handling situation with sort_fn="random", and delegating the rest to the its parent class.

def filter_count(self, image_np: NdarrayOrTensor, locations: np.ndarray) -> tuple[NdarrayOrTensor, np.ndarray]:
    if self.sort_fn == GridPatchSort.RANDOM:
        pass # do your logic for random sorting here
        return image_np, locations
    return super().filter_count(image_np, locations)

[drbeh]

Also it would be great if you can update docstring for RandGridPatchd (the dictionary version of the transform) for this new option ("random") too. Thanks

[jmnolte]

Thanks to everyone for the reviews. As per popular request from @wyli and @drbeh, I have now adapted the random sorting option to only be implemented in the class' randomised version RandGridPatch.

[jmnolte]

Thanks for the feedback! I have now created a new filter_count method in RandGridPatch that overrides the parent's method if sort_fn=random. Let me know what you think.

[wyli]

thanks, it looks good to me -- please help fix the typing error

[KumoLiu]

Thanks for the quick update, LGTM. Could you please help also update the docstring in the RandGridPatchd?

[jmnolte]

I am not quite sure, what's causing the typing error. It appears that the index is of an invalid type but I don't see how the index type returned from GridPatchSort.RANDOM is different from the type returned from the other sorting options. Could anyone take a look?

[wyli]

sure, I'll have a look and trigger more tests @jmnolte.

[wyli]

/build

[drbeh]

Thanks for addressing the comments. LGTM!