Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6717 fixes current_mode check in convert_applied_interp_mode #6719

Merged
merged 2 commits into from
Jul 14, 2023
Merged

6717 fixes current_mode check in convert_applied_interp_mode #6719

merged 2 commits into from
Jul 14, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 14, 2023

Fixes #6717.

Add int check for current_mode in convert_applied_interp_mode.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6717
334359e 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu mentioned this pull request Jul 14, 2023
Closed
wyli
wyli approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Jul 14, 2023

/build

@wyli wyli enabled auto-merge (squash) July 14, 2023 08:41
@wyli
Copy link
Contributor

wyli commented Jul 14, 2023

/build

@wyli wyli merged commit 3b6b11a into Project-MONAI:dev Jul 14, 2023
28 of 32 checks passed
@KumoLiu KumoLiu deleted the fix-invert branch July 18, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invertd error when using spline interpolation order 0-5 (integers) in spacing transform
2 participants
@KumoLiu @wyli