Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update base image to 2306 #6741

Merged
merged 5 commits into from
Jul 20, 2023
Merged

update base image to 2306 #6741

merged 5 commits into from
Jul 20, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 19, 2023

Fixes #6740

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor Author

wyli commented Jul 19, 2023

/build

wyli added 3 commits July 19, 2023 20:16
@wyli
testing 2306
75973ee 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp test
035d168 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp tests
87a3e0a 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update
620dda0 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
remove temp
0358f5e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review July 19, 2023 20:13
@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu July 19, 2023 20:14
KumoLiu
KumoLiu approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@wyli
Copy link
Contributor Author

wyli commented Jul 20, 2023

/build

@wyli wyli enabled auto-merge (squash) July 20, 2023 05:38
@wyli wyli merged commit 4addc5d into Project-MONAI:dev Jul 20, 2023
32 checks passed
@wyli wyli deleted the update-2306 branch July 20, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update to integration test with pytorch 23.06
2 participants
@wyli @KumoLiu