Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Ports generative networks #7196

Closed
wants to merge 12 commits into from

Makes vector quantizier compatible with mypy

8602212
Select commit
Loading
Failed to load commit list.
Closed

[WIP]Ports generative networks #7196

Makes vector quantizier compatible with mypy
8602212
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Nov 22, 2023 in 1s

DCO

There are 11 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Preferred method: Commit author adds a DCO remediation commit

A DCO Remediation Commit contains special text in the commit message that applies a missing Signed-off-by line in a subsequent commit. The primary benefit of this method is that the project’s history does not change, and there is no risk of breaking someone else’s work.

These authors can unblock this PR by adding a new commit to this branch with the following text in their commit message:

Mark Graham <[email protected]>

DCO Remediation Commit for Mark Graham <[email protected]>

I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 994d0e79909c03f71eaadd0a7921c1682b82f0b1
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: cdd8b7f780b37f5e44a5f6ac0057778a4aeb9f2f
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 844f7bda3d3c8fc94e14cf010fbecfa9389c60e5
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 4eba0e766c6d7152920b51a84ed7885785a619ad
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: d5d247b7cac5984cee89df8d4c6d5427fa786e5c
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: b2a19d11a92d21ff183556d070c5b1cc7a4b3105
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 42372338030318d1839eda32b6fda15bfdbe08d4
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 103e6e091d8fa37cefe3988f82e0d6eeab82b076
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: e9c483acfe530095f67bb860fd4c7c70ab71ae55
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: b9ff39c84dabaf04d67f8eb11e2bfbe94914c71c
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 8602212a31044f85ca70cb9a4387c67cb51f45e1

Signed-off-by: Mark Graham <[email protected]>

Please note: You should avoid adding empty commits (i.e., git commit -s --allow-empty), because these will be discarded if someone rebases the branch / repo.


Least preferred method: Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~12 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin 6676_port_generative_networks

Summary

Commit sha: 994d0e7, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: cdd8b7f, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: 844f7bd, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: 4eba0e7, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: d5d247b, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: b2a19d1, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: 4237233, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: 103e6e0, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: e9c483a, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: b9ff39c, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.
Commit sha: 8602212, Author: Mark Graham, Committer: Mark Graham; The sign-off is missing.