Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geom api #7490

Closed
wants to merge 3 commits into from
Closed

Geom api #7490

wants to merge 3 commits into from

Conversation

atbenmurray
Copy link
Contributor

@atbenmurray atbenmurray commented Feb 23, 2024

Fixes #7486.

This PR is an investigation of the API changes required to implement #7486. As it stands, it isn't yet intended to be the PR for the API changes, but it could turn into it if everyone is happy with it.

Description

API changes required to support raster and geometry tensors. So far this means:

  • MapTransform minor API extension
  • Spatial dictionary transforms (which may need no API extension)
  • Spatial array transforms (which will likely need API extensions)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@atbenmurray
Copy link
Contributor Author

@KumoLiu @Nic-Ma @ericspod I think we can close this PR. I have a branch on my fork of MONAI that significantly updates this work.

@KumoLiu
Copy link
Contributor

KumoLiu commented Oct 25, 2024

@atbenmurray Sure, close for now. And you can create any further pr later. Thanks

@KumoLiu KumoLiu closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometric transforms proposal
2 participants