Addition of SPADE Network + tests and modification of SPADE normalisation #7775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 16, 2024 10:34
- spade_network, and SPADENet (VAE-GAN) - test_spade_vaegan (to test previously mentioned model) Modification of: - spade_diffusion_model_unet.py to change namings. - SPADE normalisation layer, to use get_norm_layer function instead of defining such layers directly.
… before, an argument, but it wasn't being used, set instead to LeakyRelu. Now, activation is a parameter that is passed. It can't be None. In addition, removal of the KLD loss object. Instead, if network is VAE, it outputs the mu and log variance in the forward so that the KLD can be calculated externally.
ericspod
reviewed
May 17, 2024
|
The quick tests are failing for some weird issue with Matplotlib that may go away if they're rerun anyway, it isn't related to this PR. The DCO can be fixed as well by following the remediation instructions. |
|
This is the final piece of #7227 The need for the addition of the spade network here is my fault - I missed it out in the initial port, and @virginiafdez spotted it. The matplotlib errors have been popping up on other PRs too, recently. Will do a review in a moment. I can help with the mypy errors too |
Signed-off-by: Mark Graham <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
I, virginiafdez <[email protected]>, hereby add my Signed-off-by to this commit: 5e3a3aa I, virginiafdez <[email protected]>, hereby add my Signed-off-by to this commit: a4547fa I, virginiafdez <[email protected]>, hereby add my Signed-off-by to this commit: c5834de I, virginiafdez <[email protected]>, hereby add my Signed-off-by to this commit: 0261386 Signed-off-by: virginiafdez <[email protected]>
Signed-off-by: virginiafdez <[email protected]>
KumoLiu
reviewed
May 22, 2024
|
Perhaps rename this PR to |
virginiafdez
changed the title
…e informative errors when z_dim is None and network is not GAN, addition of docstrings in forward method and __all__. - Modification of flag is_gan in the Decoder, to change it to opposite flag is_vae, to make it match with the flag of the SPADE network. - Modification of functionality on NOT is_vae mode. Initially, a random Gaussian noise vector was drawn and passed to an input Linear layer. Nonetheless, the original SPADE code starts from an interpolated version of the semantic map (deterministically) and passes it to a conv layer. self.fc is changed to a Conv layer when is_vae is False. Because mypy does not allow for self.fc to be Linear or Convolution under different attribute values, self.fc > self.conv_init when is_vae is False. - Modification of tests to incorporate suggestions: name of the tests were unsuitable, there were missing scenarios for when is_vae = False. Signed-off-by: virginiafdez <[email protected]>
KumoLiu
reviewed
May 28, 2024
|
/build |
Signed-off-by: virginiafdez <[email protected]>
|
/build |
1 similar comment
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.