Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch inference multithread buffer #1451

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

drbeh
Copy link
Member

@drbeh drbeh commented Jul 10, 2023

Description

This PR added a section to modular patch inference notebook to demonstrate the multithread buffer for batch sampling.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drbeh drbeh requested a review from KumoLiu July 10, 2023 19:28
@drbeh
Copy link
Member Author

drbeh commented Jul 10, 2023

Requires Project-MONAI/MONAI#6139 to be merged first.

@drbeh
Copy link
Member Author

drbeh commented Jul 16, 2023

Hi @KumoLiu, can you take a look here? Thanks

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, LGTM. Thanks!

@drbeh drbeh merged commit 338a962 into Project-MONAI:main Jul 16, 2023
5 checks passed
@drbeh drbeh deleted the multi-thread-patch-inference branch July 16, 2023 15:27
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
### Description
This PR added a section to modular patch inference notebook to
demonstrate the multithread buffer for batch sampling.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants