fix reference implementation for updateStatus scale-down

ProjectOpenSea · Mar 5, 2024 · ab953c5 · ab953c5
1 parent 941831b
commit ab953c5
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/reference/lib/ReferenceOrderValidator.sol b/reference/lib/ReferenceOrderValidator.sol
@@ -323,13 +323,9 @@ contract ReferenceOrderValidator is
                     || denominator > type(uint120).max
             ) {
                 // Derive greatest common divisor using euclidean algorithm.
-                uint256 scaleDown = _greatestCommonDivisor(
-                    numerator,
-                    _greatestCommonDivisor(filledNumerator, denominator)
-                );
+                uint256 scaleDown = _greatestCommonDivisor(filledNumerator, denominator);
 
-                // Scale all fractional values down by gcd.
-                numerator = numerator / scaleDown;
+                // Scale new filled fractional values down by gcd.
                 filledNumerator = filledNumerator / scaleDown;
                 denominator = denominator / scaleDown;