Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves experimental_warn setting to experiments model and removes async_fetch_state_result #4

Open
wants to merge 1 commit into
base: frances/test_promptless3
Choose a base branch
from

Conversation

frances720
Copy link

@frances720 frances720 commented Nov 5, 2024

This PR takes care of two settings on the root model that shouldn't be there long term:

experimental_warn is moved to experiments.warn
async_fetch_state_result is removed and the default behavior for fetching results is updated to match this setting being enabled. The corresponding fetch kwargs are also deprecated so we can eventually clean all that up.

Copy link

promptless bot commented Nov 5, 2024

📝 Documentation updates detected!

Promptless has analyzed your changes and created a documentation update PR. You can review the proposed documentation changes here:
#5

Please review the suggested updates to ensure they accurately reflect your changes.

Copy link

promptless bot commented Nov 5, 2024

📝 Documentation updates detected!

Promptless has analyzed your changes and created a documentation update PR. You can review the proposed documentation changes here:
#6

Please review the suggested updates to ensure they accurately reflect your changes.

@frances720 frances720 changed the title Moves experimental_warn setting to experiments model and removes … Moves experimental_warn setting to experiments model and removes async_fetch_state_result Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants