-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2x splash image for Mac port with Retina display. #389
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mituharu! LGTM
In relation to that, I'd also like to improve toolbar icons on Retina displays (and Dark Mode on macOS 10.14).
README in the images directory tells that most of the images are created with Gimp and Inkscape.
If the toolbar icons are originally created as larger bitmaps or resolution-independent data like SVG and the original data are available somewhere, then I can generate high-resolution toolbar icons for Retina displays as multi-image TIFF data that Emacs Mac port prefers.
I don't know if such sources are available somewhere... Maybe @DavidAspinall would know?
Slightly off-topic, but: is there any reason not to use SVG icons directly? |
Because it takes time to setup WebKit (used for rendering SVG images in the Mac port) and makes startup slow. |
Emacs built with GTK+ first tries to let GTK+ render toolbar icon images and falls back on Emacs's own image rendering (see xg_get_image_for_pixmap in gtkutil.c). That's why SVG in the toolbar on GTK+ supports alpha channel but not inside Emacs buffers. |
Do we want to merge this as is? IS there something more to do? |
Emacs Mac port supports high-resolution (2x) image display for Retina displays.
One way to do that is just to add a file [email protected] in parallel with existing NAME.EXT (no need to change Lisp code).
This pull request adds a 2x splash screen image so it looks crispier on Retina displays.
In relation to that, I'd also like to improve toolbar icons on Retina displays (and Dark Mode on macOS 10.14).
README in the
images
directory tells that most of the images are created with Gimp and Inkscape.If the toolbar icons are originally created as larger bitmaps or resolution-independent data like SVG and the original data are available somewhere, then I can generate high-resolution toolbar icons for Retina displays as multi-image TIFF data that Emacs Mac port prefers.