Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lib to use 2024 version of wpilibNewCommands #15

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

kcooney
Copy link
Contributor

@kcooney kcooney commented Jan 28, 2024

The code in Robot2024 already uses this version.

  • Copy WPILibNewCommands.json from vendordeps/ to lib/vendordeps
  • Remove wpilibNewCommands from lib/build.gradle
  • Remove override of MotorSubsystem.setSetpoint(double) (this method is now final in the
    base class)

@kcooney kcooney force-pushed the kevin/fix-vendor-deps branch 4 times, most recently from a9d5d98 to 40b2d10 Compare January 28, 2024 23:47
The code in Robot2024 already uses this version.

- Copy WPILibNewCommands.json from vendordeps/ to lib/vendordeps
- Remove wpilibNewCommands from lib/build.gradle
@cuttestkittensrule cuttestkittensrule merged commit 9918aad into master Jan 29, 2024
1 check passed
@kcooney kcooney deleted the kevin/fix-vendor-deps branch February 9, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants