generateForwardingMaterial: set forwarding flag on encryption subkeys
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A specific flag needs to be set for forwarding subkeys instead of the standard EtEr ones. In fact, encrypting to them directly is not allowed. Also, setting `config.allowForwardedMessages` is now required to decrypt (this was previously not enforced due to a bug in OpenPGP.js)
twiss
reviewed
Sep 6, 2023
twiss
approved these changes
Sep 6, 2023
larabr
added a commit
to larabr/pmcrypto
that referenced
this pull request
Feb 20, 2024
…ys (ProtonMail#184) A specific flag needs to be set for forwarding subkeys instead of the standard EtEr ones. In fact, encrypting to them directly is not allowed. Also, setting `config.allowForwardedMessages` is now required to decrypt (this was previously not enforced due to a bug in OpenPGP.js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specific flag needs to be set for forwarding subkeys instead of the standard EtEr ones. In fact, encrypting to them directly is not allowed.
Also, setting
config.allowForwardedMessagesis now required to decrypt (this was previously not enforced due to a bug in OpenPGP.js)