Adds mainnet deployment script #265
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@loothero has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 38 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request introduces a new script, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant StarkNet
User->>Script: Execute deploy_mainnet.sh
Script->>Script: Define addresses and parameters
Script->>Script: Source environment variables
Script->>Script: Build game contract using scarb
Script->>StarkNet: Deploy renderer and game contracts
StarkNet-->>Script: Confirm deployment
Script-->>User: Deployment complete
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
scripts/deploy_mainnet.sh (1)
51-57: Update settings and correct comment syntax inscripts/deploy_mainnet.sh.The TODO comment indicating that settings need to be updated before the full release is still present in the file. Please ensure these settings are finalized. Additionally, replace
//with#for comments in bash scripts.
- Location:
scripts/deploy_mainnet.sh, lines 51-57Analysis chain
Update the settings and use
#for comments before the full release.The comment block contains TODO and temporary settings for the launch tournament and free VRF promotion. Please ensure to update these settings with the final values before the full release.
Also, use
#instead of//for comments in bash scripts.Ensure that the settings are updated before the full release by running the following script:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the settings are updated before the full release. # Test: Search for the TODO comment. Expect: No occurrences. rg --type sh $'// TODO: UPDATE THESE SETTINGS BEFORE FULL RELEASE'Length of output: 144
Tools
Shellcheck
[error] 51-51: Was this intended as a comment? Use # in sh.
(SC1127)
[error] 52-52: Was this intended as a comment? Use # in sh.
(SC1127)
[error] 53-53: Was this intended as a comment? Use # in sh.
(SC1127)
[error] 55-55: Was this intended as a comment? Use # in sh.
(SC1127)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- scripts/deploy_mainnet.sh (1 hunks)
Additional context used
Gitleaks
scripts/deploy_mainnet.sh
11-12: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Shellcheck
scripts/deploy_mainnet.sh
[error] 51-51: Was this intended as a comment? Use # in sh.
(SC1127)
[error] 52-52: Was this intended as a comment? Use # in sh.
(SC1127)
[error] 53-53: Was this intended as a comment? Use # in sh.
(SC1127)
[error] 55-55: Was this intended as a comment? Use # in sh.
(SC1127)
[warning] 60-60: ShellCheck can't follow non-constant source. Use a directive to specify location.
(SC1090)
[warning] 63-63: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
[warning] 73-73: renderer_class_hash is referenced but not assigned.
(SC2154)
[warning] 76-76: game_contract appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 76-76: launch_tournament_duration_seconds is referenced but not assigned.
(SC2154)
[warning] 76-76: game_start_delay is referenced but not assigned.
(SC2154)
Additional comments not posted (2)
scripts/deploy_mainnet.sh (2)
59-60: LGTM!Sourcing environment variables from a file is a good practice for security and maintainability.
Tools
Shellcheck
[warning] 60-60: ShellCheck can't follow non-constant source. Use a directive to specify location.
(SC1090)
67-76: LGTM!The deployment commands look good. The script correctly declares and deploys the renderer and game contracts using the
starklitool, capturing the necessary class hashes and addresses in variables.Tools
Shellcheck
[warning] 73-73: renderer_class_hash is referenced but not assigned.
(SC2154)
[warning] 76-76: game_contract appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 76-76: launch_tournament_duration_seconds is referenced but not assigned.
(SC2154)
[warning] 76-76: game_start_delay is referenced but not assigned.
(SC2154)
| source $ENV_FILE | ||
|
|
||
| # build game contract | ||
| cd /workspaces/loot-survivor/contracts/ |
There was a problem hiding this comment.
Handle the case where cd fails.
Please use cd ... || exit to handle the case where cd fails. This will ensure that the script exits if it cannot change to the correct directory, preventing unexpected behavior.
Apply this diff to fix the issue:
-cd /workspaces/loot-survivor/contracts/
+cd /workspaces/loot-survivor/contracts/ || exit 1Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cd /workspaces/loot-survivor/contracts/ | |
| cd /workspaces/loot-survivor/contracts/ || exit 1 |
Tools
Shellcheck
[warning] 63-63: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
(SC2164)
Summary by CodeRabbit
New Features
Improvements