Very simple revamp of dead code elimination. #28507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebenfield
force-pushed
the
dead-code-class
branch
3 times, most recently
from
2867c59 to
460bc34
Compare
d0cd
reviewed
Feb 13, 2025
| @@ -16,6 +16,7 @@ closure eliminate_unused_function_call: | |||
| function foo: | |||
| input r0 as u8.private; | |||
| input r1 as u8.private; | |||
| add r0 r1 into r2; | |||
| output r2 as u8.private; | |||
| call eliminate_unused_function_call r0 r1 into r2; | |||
There was a problem hiding this comment.
Should this call be eliminated?
Enable DCE by default. Eliminates useless associated function calls. Also threw in just a few changes to Display implementations for some nodes. Fixes #28504
mikebenfield
force-pushed
the
dead-code-class
branch
from
460bc34 to
7201b3d
Compare
|
Alright see what you think of these changes. Also eliminates a couple new calls, in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable DCE by default. Eliminates useless
associated function calls.
Also threw in just a few changes to Display
implementations for some nodes.
Fixes #28504